Moved pre-processing step to Core ML class #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellbosch
commented
Mar 25, 2021
| @@ -72,6 +72,11 @@ class PredictionLayer: NSObject { | |||
| } | |||
| onComplete(request) | |||
| }) | |||
|
|
|||
| /// Set center cropping for the expected image size. | |||
There was a problem hiding this comment.
@mbeissinger comment code here for your review.
| @@ -37,11 +37,7 @@ class PlayViewModel: ObservableObject { | |||
| .compactMap { $0 } // remove non-nill values | |||
| .receive(on: DispatchQueue.global(qos: .userInitiated)) | |||
| .sink(receiveValue: { [weak self] image in | |||
| guard let squaredImage = image.squared() else { | |||
mbeissinger
approved these changes
Mar 26, 2021
| @@ -72,6 +72,11 @@ class PredictionLayer: NSObject { | |||
| } | |||
| onComplete(request) | |||
| }) | |||
|
|
|||
| /// Set center cropping for the expected image size. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offloads image preprocessing to the Vision class in Core ML. This should make us better prepared for possible changes to expected image input size in the future.
Because:
This commit:
.centerCropto theVNCoreMLRequestobject.LobeMLfile in the project menu, for kicks.Tagging #22 because there's a chance that bug gets fixed with this change.